Add support for ImmutableList<T> as the recursive collection#71
Open
Add support for ImmutableList<T> as the recursive collection#71
Conversation
This is consistent with the Dev14 API for project trees.
ImmutableList`1.RemoveRange does not enumerate its argument when the list is empty. ImmutableSortedSet`1.Except *does* enumerate its argument even when the collection is empty. This difference in behavior caused a test failure when preparing ProjectTree to change to use ordered Children instead of sorted children. This change makes sure that every element in the argument is "realized" from the enumerable, and thus exceptions are reliably thrown.
Owner
Author
|
Some of the tests that were modified are assertion 'current' behavior even though that behavior isn't desirable. For example, Ideally, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69